stevedlawrence commented on a change in pull request #394:
URL: https://github.com/apache/incubator-daffodil/pull/394#discussion_r454298618
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala
##########
@@ -53,9 +54,9 @@ trait TypeBase {
trait NonPrimTypeMixin
sealed trait SimpleTypeBase extends TypeBase
- with HasOptRepTypeMixin {
+ with HasOptRepTypeMixin with SimpleTypeView {
- def primType: PrimType
+ override def primType: PrimType
Review comment:
Doesn't seem unreasonable. I had forgotten that NodeInfo is defined in
daffodil-runtime1. The problem is daffodil-core depends on daffodil-runtime1,
(core creates many of the objects defined in runtime1), so runtime1 can't use
anything defined in core or we'd have a circular dependency. They way you
handled it seems reasonable.
If you wanted to do it with mixin views, you would need to define the
PrimTypeView traits in the daffodil-runtime1 class. They can still be in a
dsom.walker package, just in a different subproject/jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
