stevedlawrence commented on a change in pull request #429:
URL: https://github.com/apache/incubator-daffodil/pull/429#discussion_r500405659
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SeparatedSequenceUnparsers.scala
##########
@@ -155,7 +165,7 @@ class OrderedSeparatedSequenceUnparser(
state: UState,
trailingSuspendedOps:
Buffer[SuppressableSeparatorUnparserSuspendableOperation]): Unit = {
- val suspendableOp = new
SuppressableSeparatorUnparserSuspendableOperation(sep, trd)
+ val suspendableOp = new
SuppressableSeparatorUnparserSuspendableOperation(sepMtaAlignmentMaybe, sep,
trd)
Review comment:
I have confirmed that this is in fact not hit by any tests (these new
codecov warnings are nice!). The new logic for alignment is tested because the
``unparseOneWithSupression`` function also creates this same suspension.
After grepping, this ``unparseJustSeparatorWithTrailingSuppression``
function is actually just never called anywhere. I suspect this is just dead
code and ``unparseOneWithSuppression`` handles all cases of suppressed
separators, including the trailing suppression case? Any idea of this can just
be removed, or if we're perhaps missing logic somewhere else and this function
should be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
