mbeckerle commented on a change in pull request #429:
URL: https://github.com/apache/incubator-daffodil/pull/429#discussion_r500502613
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SeparatedSequenceUnparsers.scala
##########
@@ -155,7 +165,7 @@ class OrderedSeparatedSequenceUnparser(
state: UState,
trailingSuspendedOps:
Buffer[SuppressableSeparatorUnparserSuspendableOperation]): Unit = {
- val suspendableOp = new
SuppressableSeparatorUnparserSuspendableOperation(sep, trd)
+ val suspendableOp = new
SuppressableSeparatorUnparserSuspendableOperation(sepMtaAlignmentMaybe, sep,
trd)
Review comment:
Yow. Well, the purpose of this must be for unparsing an empty element
that is not trailing, so not trailing suppressed. There are some bugs about
separatorSuppressionPolicy="never" which this code might be in service of.
DAFFODIL-2219 is one.
Put a nice big comment in here with a FIXME: possibly dead code, but maybe
needed to fix separatorSuppressionPolicy bugs like DAFFODIL-2219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
