mbeckerle commented on a change in pull request #429:
URL: https://github.com/apache/incubator-daffodil/pull/429#discussion_r500992781
##########
File path:
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd
##########
@@ -400,6 +400,32 @@
</xs:documentation>
</xs:annotation>
</xs:element>
+ <xs:element name="unparseSuspensionWaitOld" type="xs:int"
default="100" minOccurs="0">
+ <xs:annotation>
+ <xs:documentation>
Review comment:
I like to put <![CDATA[... ]]> around blocks of doc text like this.
Seems to tell tooling not to mess up the line indentation and such.
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/SuspensionTracker.scala
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.daffodil.processors
+
+import scala.collection.mutable.Queue
+
+import org.apache.daffodil.dsom.RuntimeSchemaDefinitionError
+import org.apache.daffodil.exceptions.Assert
+
+class SuspensionTracker(suspensionWaitYoung: Int, suspensionWaitOld: Int) {
+
+ private val suspensionsYoung = new Queue[Suspension]
+ private val suspensionsOld = new Queue[Suspension]
+
+ private var count: Int = 0
+
+ def trackSuspension(s: Suspension): Unit = {
+ suspensionsYoung.enqueue(s)
+ }
+
+ /**
+ * Attempts to evaluate suspensions. Old suspensions are evaluated less
+ * frequently than young suspensions. Any young suspensions that fail to
+ * evaluate are moved to the old suspensions list. If we evaluate old
+ * suspensions, we attempt to evaluate them first, with the hope that their
+ * resolution might make the young suspensions more likely to evaluate.
+ */
+ def evalSuspensions(): Unit = {
Review comment:
Besides absolute measures of performance I think we should keep a count
of how many times a suspension is evaluated only to be put back on a queue. A
useful efficiency measure. We might want a tunable to turn on/off reporting
this at end of a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
