stevedlawrence commented on a change in pull request #431:
URL: https://github.com/apache/incubator-daffodil/pull/431#discussion_r504152083
##########
File path:
daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
##########
@@ -73,6 +73,8 @@ private[japi] object ValidationConversions {
case ValidationMode.Off => SValidationMode.Off
case ValidationMode.Limited => SValidationMode.Limited
case ValidationMode.Full => SValidationMode.Full
+ // todo;; support custom in java?
+ case _ => SValidationMode.Off
Review comment:
Do we really need the Arguments for the API? Could the API be something
maybe a bit simpler, e.g.
```scala
val myValidator = new MyCustomValidator(...)
dp.withValidation(Validation.Custom, myValidator)
```
So if you are using the API, then we expect you to allocate a new validator
and we provide an API method to provide it to Daffodil. One potential issue is
what if the validator isn't threadsafe (I believe Xerces isn't?), but perhaps
the CustomValidator should be expected to handle that if they arent thread safe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
