jw3 commented on pull request #431: URL: https://github.com/apache/incubator-daffodil/pull/431#issuecomment-707949452
> I'd like to also comment on the schematron validator. > > I think we should fold it into Daffodil's source tree. I know you are trying to have an example of how to do it outside of daffodil, which is fine, but we need to be able to review that also. > > For example, it is printing things. It should be creating some sort of ValidationError instances, and adding them to validation errors somewhere, not printing. @mbeckerle I am fine with rolling it in if you want it. IMO it would be better to get the SPI changes merged while working as close to possible as the way the validator was previously working, and then in additional PRs add schematron and add other nice to haves. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
