mbeckerle commented on pull request #437: URL: https://github.com/apache/incubator-daffodil/pull/437#issuecomment-710739993
That seems like a better choice. We just mark the nodes and convert to an XML attribute. ________________________________ From: Steve Lawrence <[email protected]> Sent: Friday, October 16, 2020 12:49:22 PM To: apache/incubator-daffodil <[email protected]> Cc: Beckerle, Mike <[email protected]>; Comment <[email protected]> Subject: Re: [apache/incubator-daffodil] Free infoset element during unparse (#437) Another thought, what if instead we make it so that if we would have freed a DINode but didn't then we modify some new state in the DNIode that says that it would have been freed. And when we output the infoset as XML we have to ability to configure it to include an attribute saying it would have been freed. Then we just have these tests disable freeing output as XML with this attribute, and then we can easily inspect the XML to determine which elements would have been freed. No concerns with elemetn children being null, and the resulting XML should look exactly like the infoset, just with extra attributes. Thoughts? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-daffodil/pull/437#issuecomment-710210484>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALUDA2A3WCXDRBQSVFUJTLSLB2RFANCNFSM4SSADTDQ>. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
