stevedlawrence commented on a change in pull request #437: URL: https://github.com/apache/incubator-daffodil/pull/437#discussion_r512913519
########## File path: daffodil-core/src/test/scala/org/apache/daffodil/infoset/TestInfosetFree.scala ########## @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.infoset + +import org.junit.Assert._ +import org.junit.Test + +import org.apache.daffodil.compiler.Compiler +import org.apache.daffodil.compiler.ProcessorFactory +import org.apache.daffodil.io.InputSourceDataInputStream +import org.apache.daffodil.processors.DataProcessor +import org.apache.daffodil.processors.parsers.PState +import org.apache.daffodil.processors.unparsers.UStateMain +import org.apache.daffodil.util.SchemaUtils + +object TestInfosetFree { + + /** + * Compiles an infoset with infoset releasing disabled. By disabling the + * releasing, the Scala infoset is marked with attributes signifying which + * elements *would* have been freed if we didn't disable it. This allows for + * a reliable way to validate which elements were freed. + * + * This first parses and unparses data, without freeing any infoset + * nodes--only marking as described above. It then walks both infosets, + * configured to add information to the infoset about which elements were + * freed. We validate that both the parse and unparse results are the + * same--any infoset elements freed during a parse should also be freed + * during unparse. We then return the infoset for the test to compare against + * the expected value. + */ + def test( + schema: scala.xml.Elem, + bytes: Array[Byte]): scala.xml.Node = { + + val compiler = Compiler() + .withTunable("releaseUnneededInfoset", "false") + + val pf = compiler.compileNode(schema).asInstanceOf[ProcessorFactory] + if (pf.isError) { + val msgs = pf.getDiagnostics.map { _.getMessage() }.mkString("\n") + fail("pf compile errors: " + msgs) + } + pf.sset.root.erd.preSerialization // force evaluation of all compile-time constructs + val dp = pf.onPath("/").asInstanceOf[DataProcessor] Review comment: We did need it because this DataProcessor has an additional helper def unparse() method that accepts an OutputStream instead of the normal WritableByteChannel. But it's better to change this test to use the WritableByteChannel instead. All unnecessary asInstanceOf's are removed and typos fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
