stevedlawrence commented on a change in pull request #460:
URL: https://github.com/apache/incubator-daffodil/pull/460#discussion_r532615540
##########
File path:
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd
##########
@@ -401,6 +471,11 @@
frequency of context switching, but increase the memory
footprint.
</xs:documentation>
</xs:annotation>
+ <xs:simpleType>
Review comment:
My only concern here, and why I went this route, is it makes the
generator quite a bit more complicated. It doesn't currently have any logic to
find other types or support restrictions not defined directly as a child of the
tunable. It's still pretty dumb. I'd prefer that we just require this schema be
verbose in favor a being easily parsable. There's plenty of ways one might want
to refactor this file (e.g. imports/includes, unions), that I don't really want
to have to support. I'd rather add comments in the schema file that specifiy
that the generator expects a certain form. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
