stevedlawrence commented on pull request #460:
URL:
https://github.com/apache/incubator-daffodil/pull/460#issuecomment-735946836
I've added a new commit to add additional validation so that we get more
helpful errors if the schema doesn't follow our strict requirements.
This found one tunable that didn't have a default because the default was
hardcoded. I changed it so the default in the XSD is the actual java code so
that it the tunable has a default, but I'm not sure I like that. This means all
properties have a default and we atually use it, but it feels wrong having java
code in the XSD. Thoughts?
```diff
- new FileTunable("tempFilePath", """System.getProperty("java.io.tmpdir")""")
+ new FileTunable("tempFilePath", schemaDefault)
```
```diff
- <xs:element name="tempFilePath" type="xs:string" default="" minOccurs="0">
+ <xs:element name="tempFilePath" type="xs:string"
default="System.getProperty("java.io.tmpdir")" minOccurs="0">
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
