mbeckerle commented on a change in pull request #450:
URL: https://github.com/apache/incubator-daffodil/pull/450#discussion_r538737060
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/VariableMap1.scala
##########
@@ -222,7 +300,7 @@ class VariableMap private(vTable: Map[GlobalQName,
MStackOf[VariableInstance]])
/**
* For testing mostly.
*/
- def getVariableBindings(qn: GlobalQName): MStackOf[VariableInstance] = {
+ def getVariableBindings(qn: GlobalQName): Queue[VariableInstance] = {
Review comment:
Well, a cheap collection class is ArrayBuffer, if we don't care about it
really being stack-like or queue-like. I guess I don't like using a Queue as a
bag if mutable set, or just array buffer is sufficient. What is the access
pattern needed here? It used to be MStack, so I'm surprised Queue works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
