mbeckerle commented on a change in pull request #450:
URL: https://github.com/apache/incubator-daffodil/pull/450#discussion_r538820328
##########
File path:
daffodil-test/src/test/scala/org/apache/daffodil/section07/variables/TestVariables.scala
##########
@@ -59,6 +59,16 @@ class TestVariables {
@Test def test_varInstance_09(): Unit = {
runner.runOneTest("varInstance_09") }
@Test def test_varInstance_10(): Unit = {
runner.runOneTest("varInstance_10") }
@Test def test_varInstance_11(): Unit = {
runner.runOneTest("varInstance_11") }
+ @Test def test_varInstance_12(): Unit = {
runner.runOneTest("varInstance_12") }
+
+ @Test def test_defineVariable_nonConstantExpression(): Unit = {
runner.runOneTest("defineVariable_nonConstantExpression") }
+ // The following tests don't seem to play nicely with TDMLRunner and the
errors are not detected/checked against
+ //@Test def test_circular_defineVariable_err(): Unit = {
runner.runOneTest("circular_defineVariable_err") }
Review comment:
I think the bug that is failing and producing a stack trace that's got
to be a TDML-runner issue. Do you have a negative test that defines two
variables that are circular. That test should be able to expect an SDE and get
it. If that's getting masked somehow, it's a TDML runner issue, or perhaps the
error is being thrown of wrong type somehow. Wants to be a compile time SDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
