jw3 commented on a change in pull request #463: URL: https://github.com/apache/incubator-daffodil/pull/463#discussion_r541006190
########## File path: daffodil-schematron/src/test/resources/xsd/embedded-1.dfdl.xsd ########## @@ -0,0 +1,24 @@ +<?xml version="1.0" encoding="utf-8" ?> +<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"; + xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"; + elementFormDefault="qualified"> + + <xs:include schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/> + <xs:annotation> + <xs:appinfo source="http://www.ogf.org/dfdl/";> + <dfdl:format ref="GeneralFormat" /> + </xs:appinfo> + </xs:annotation> + + <xs:element name="uuid" type="xs:string" dfdl:lengthKind="delimited" dfdl:terminator="%NL;"> Review comment: Updated. Is that change enough to cover that the rule is properly scoped to the context? Working on improving my daffodil schema understanding at the same time as adding more complex tests and working with the JPEG schema... :turtle: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
