jw3 commented on a change in pull request #463:
URL: https://github.com/apache/incubator-daffodil/pull/463#discussion_r542573243
##########
File path: daffodil-schematron/src/test/resources/xsd/embedded-1.dfdl.xsd
##########
@@ -30,13 +30,19 @@
<sch:assert test="substring(.,9,1)='-' and
substring(.,14,1)='-' and substring(.,19,1)='-' and
substring(.,24,1)='-'">malformed uuid</sch:assert>
</sch:rule>
</sch:pattern>
+ <sch:pattern name="test-short-uuid">
+ <sch:rule context="short-uuid">
+ <sch:assert test="string-length(.)=8">short uuid must be 8
chars</sch:assert>
Review comment:
> I was expecting to see this rule as an annotation on the element
declaration of short-uuid below.
The first pass had it embedded and it looked like it was going to get noisy.
I can see advantages of both.. will add an example back in for
demonstration.
> W.r.t this test, I was hoping for a test using a sch rule that would use
some relative paths like ../../foo/bar to reach around in the infoset and
constrain disparate things together.
I see. Will add examples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
