regetom commented on pull request #481: URL: https://github.com/apache/daffodil/pull/481#issuecomment-796730320
Previously, I had 23 testing failing. after applying Steve's suggested change above, only 16 tests failed. Of the 16 tests still failing, many were failing to a verbiage change in the error message. Specifically 9 test failed because they were looking for the "cannot" in the diagnostic message. I could not find the code that set "cannot" requirement, so I changed the error message verbiage from "... contains disallowed character classes ..." to "... cannot contain character classes ..." this change corrected 9 of the test failures. The remaining test failures require more specific diagnostic meesages. For example: [error] Test org.apache.daffodil.section13.text_number_props.TestTextNumberProps.test_infCharClasses failed: org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) Did not find diagnostic message "textStandardInfinityRep cannot contain %NL;" in any of the actual diagnostic messages: [error] Schema Definition Error: Property dfdl:textStandardInfinityRep cannot contain character classes: %NL; I modified the diagnostic message again, removing "cahracter classes" and all the tests passed. I'll check the code in with these changes. If the diagnostic verbiage "... contains disallowed character classes ..." is preferred, please point me to where in the code this would need to be modified. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
