regetom commented on pull request #481: URL: https://github.com/apache/daffodil/pull/481#issuecomment-800250342
I have one more test that is failing. It appears to also occur in class DelimiterCookerNoES. Previous to the modification, the error message was coded as: //context.schemaDefinitionUnless(raw != "%ES;", "Property dfdl:%s cannot contain %%ES; when dfdl:lengthKind=\"delimited\".", propName) The modification produces the error message: Property dfdl:terminator cannot contain %ES; The resulting failure is: [error] Test org.apache.daffodil.section06.entities.TestEntities.test_emptyStringEntityTermInExpressionDelimited_01 failed: org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) Did not find diagnostic message "dfdl:lengthKind="delimited"" in any of the actual diagnostic messages: [error] Schema Definition Error: Property dfdl:terminator cannot contain %ES; The dfdl:lengthKind=terminator is the actual error message appears to come from here: <xs:schema dafint:file="file:/C:/Users/regis.thomas/incubator-daffodil/daffodil-test/target/scala-2.12/test-classes/org/apache/daffodil/section06/entities/Entities.tdml" targetNamespace="http://example.com"; elementFormDefault="qualified" xmlns:dfdlx="http://www.ogf.org/dfdl/dfdl-1.0/extensions"; xmlns="http://example.com"; xmlns:dafint="urn:ogf:dfdl:2013:imp:daffodil.apache.org:2018:int" xmlns:fn="http://www.w3.org/2005/xpath-functions"; xmlns:tns="http://example.com"; xmlns:ex="http://example.com"; xmlns:ct="http://w3.ibm.com/xmlns/dfdl/ctInfoset"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xmlns:tdml="http://www.ibm.com/xmlns/dfdl/testData";> <xs:include dafint:line="1208" dafint:col="6" schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd"/> <xs:annotation> <xs:appinfo source="http://www.ogf.org/dfdl/";> <dfdl:format dafint:line="1209" dafint:col="6" terminator="" initiatedContent="no" initiator="" textNumberRep="standard" ignoreCase="no" byteOrder="bigEndian" separator="" encoding="US-ASCII" representation="text" ref="ex:GeneralFormat"/> </xs:appinfo> </xs:annotation> <xs:element dafint:line="1213" dafint:col="6" dfdl:lengthKind="implicit" name="root"> <xs:complexType dafint:line="1214" dafint:col="8"> <xs:sequence dafint:line="1215" dafint:col="10"> <xs:element dafint:line="1216" dafint:col="12" dfdl:length="1" dfdl:lengthKind="explicit" type="xs:string" name="key"/> <xs:element dafint:line="1217" dafint:col="12" dfdl:terminator="{ if (../ex:key eq '1') then '%ES;' else 'END' }" dfdl:lengthKind="delimited" type="xs:string" name="value"/> </xs:sequence> </xs:complexType> </xs:element> </xs:schema> I'm not sure how to fix this without reverting the code in DelimiterCookerNoES back to hardcode the dfdl:lengthKind to delimited. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
