jw3 commented on a change in pull request #520:
URL: https://github.com/apache/daffodil/pull/520#discussion_r608127858
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DataProcessor.scala
##########
@@ -685,6 +685,8 @@ class ParseResult(dp: DataProcessor, override val
resultState: PState)
extends DFDL.ParseResult
with WithDiagnosticsImpl {
+ private var valres: Option[ValidationResult] = None
Review comment:
Yeah, Id thought about that sort of change too, not a fan of the var,
but it seemed like it would grow the scope of this PR more than I liked so
avoided it.
Will take a quick look to see how much it would involve to do that refactor.
I wouldnt mind doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
