jw3 commented on a change in pull request #520:
URL: https://github.com/apache/daffodil/pull/520#discussion_r608301743
##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -866,6 +867,12 @@ class ParseResult private[japi] (pr: SParseResult,
deprecatedOutput: Maybe[JDOMI
* @return true if any validation errors occurred, false otherwise.
*/
def isValidationError(): Boolean = pr.isValidationError
+
+ /**
+ * Optional result of the infoset validation.
+ * @return optional ValidationResult
+ */
+ def validationResult(): Option[ValidationResult] = pr.validationResult()
Review comment:
So looking at what is involved here, and thinking about the comment
above...
> Is the intention to keep this a sort of internal/experimental API until
all the new validation stuff is run through its paces?
The only immediate use of this raw capability is for the CLI. Is there any
value in publishing this API to the SAPI and JAPI now? Or would it be just as
well to let it internal until there is demand.
I lean toward removing the additions I made to SAPI/JAPI and only exposing
it through the CLI for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
