stevedlawrence commented on a change in pull request #525:
URL: https://github.com/apache/daffodil/pull/525#discussion_r612371889



##########
File path: README.md
##########
@@ -23,107 +26,134 @@
 [<img 
src="https://img.shields.io/maven-central/v/org.apache.daffodil/daffodil-core_2.12.svg?color=brightgreen&label=version";
 align="right"/>][Releases]
 <br clear="both" />
 
-Apache Daffodil is an open-source implementation of the [DFDL specification]
-that uses DFDL data descriptions to parse fixed format data into an infoset.
-This infoset is commonly converted into XML or JSON to enable the use of
-well-established XML or JSON technologies and libraries to consume, inspect,
-and manipulate fixed format data in existing solutions. Daffodil is also
-capable of serializing or "unparsing" data back to the original data format.
-The DFDL infoset can also be converted directly to/from the data structures
-carried by data processing frameworks so as to bypass any XML/JSON overheads.
+Apache Daffodil is an open-source implementation of the [DFDL
+specification] that uses DFDL data descriptions to parse fixed format
+data into an infoset.  This infoset is commonly converted into XML or
+JSON to enable the use of well-established XML or JSON technologies
+and libraries to consume, inspect, and manipulate fixed format data in
+existing solutions.  Daffodil is also capable of serializing or
+"unparsing" data back to the original data format.  The DFDL infoset
+can also be converted directly to/from the data structures carried by
+data processing frameworks so as to bypass any XML/JSON overheads.
 
-For more information about Daffodil, see https://daffodil.apache.org/.
+For more information about Daffodil, see the [Website].
 
 ## Build Requirements
 
 * JDK 8 or higher
 * SBT 0.13.8 or higher
-* C compiler (for daffodil-runtime2 only)
-* Mini-XML Version 3.2 or higher (for daffodil-runtime2 only)
+* C compiler C99 or higher
+* Mini-XML Version 3.2 or higher
+
+Since Daffodil has a DFDL to C backend, you will need a C compiler
+([gcc] or [clang]), the [Mini-XML] library, and possibly the GNU
+[argp] library if your system's C library doesn't include it.  You can
+install gcc and libmxml as system packages on most Unix based
+platforms with distribution-specific packager commands such as (Debian
+and Ubuntu):
+
+    # Just mentioning all other packages you might need too
+    sudo apt install build-essential curl git libmxml-dev

Review comment:
       Another thought, we could make build setup instructions for different 
distos collapsable: 
https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab
   
   That way it doesn't make the README huge by default, but has the information 
people need if they need it. For example:
   
   ## Build Setup
   
   <details>
     <summary>Fedora</summary>
     
   ```
   sudo dnf install ...
   ```
   More stuff here
   </details>
   
   <details>
     <summary>Ubuntu/Debian</summary>
     
   ```
   sudo apt install ...
   ```
   More stuff here
   </details>
   
   <details>
     <summary>Windows</summary>
     
   Windows Instructions here
   </details>




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to