stevedlawrence commented on a change in pull request #525:
URL: https://github.com/apache/daffodil/pull/525#discussion_r614151560
##########
File path: build.sbt
##########
@@ -68,8 +68,8 @@ lazy val runtime2 = Project("daffodil-runtime2",
file("daffodil-runtime2
.settings(commonSettings)
.settings(publishArtifact in (Compile,
packageDoc) := false)
.settings(
- Compile / cCompiler := "cc",
- Compile / ccArchiveCommand := "ar",
+ Compile / cCompiler := sys.env.getOrElse("CC",
"cc"),
+ Compile / ccArchiveCommand :=
sys.env.getOrElse("AR", "ar"),
Review comment:
Not sure if there's a simple way to do it. If all that's really needed
is to install a compiler and mini xml, I dont't think it's worth it. I think
maybe if we get more runtimes or more devs focusing on different runtimes, it
might be worth figuring out how to make things more pluggable so people can
really only focus on runtimes they care about (as long as CI continues to test
all runtimes). But for now, I dont' think it's a big deal. And it will also
force people to test it, which is probably important until we get more people
working on runtime2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
