jw3 commented on a change in pull request #520:
URL: https://github.com/apache/daffodil/pull/520#discussion_r614750565
##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -866,6 +867,12 @@ class ParseResult private[japi] (pr: SParseResult,
deprecatedOutput: Maybe[JDOMI
* @return true if any validation errors occurred, false otherwise.
*/
def isValidationError(): Boolean = pr.isValidationError
+
+ /**
+ * Optional result of the infoset validation.
+ * @return optional ValidationResult
+ */
+ def validationResult(): Option[ValidationResult] = pr.validationResult()
Review comment:
Have wrestled with the refactors here, they grow the size of this PR
pretty quick. I am thinking this to get this functionality in but avoid adding
things we dont need.
1. Drop the raw stream, the validator can write the output based on config
passed into it
2. Revert all changes to CLI, we already have support for the conf file
being passed. Ill write a test for that and it can be used to configure the
validator to output svrl for now. The refactor to multiple validator args can
be separate PR.
3. Keep the other refactors in Schematron and Parse Result
Ill follow up with a ticket something like "Refactor validator CLI argument
passing" with the description from above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
