mbeckerle commented on a change in pull request #532:
URL: https://github.com/apache/daffodil/pull/532#discussion_r617600385



##########
File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
##########
@@ -502,11 +502,47 @@ class CLIConf(arguments: Array[String]) extends 
scallop.ScallopConf(arguments)
     val info = tally(descr = "increment test result information output level, 
one level for each -i")
   }
 
+  // Generate Subcommand Options
+  object generate extends scallop.Subcommand("generate") {
+    descr("generate <language> code from a DFDL schema")
+
+    banner("""|Usage: daffodil [GLOBAL_OPTS] generate <language> 
[SUBCOMMAND_OPTS]
+              |""".stripMargin)
+    shortSubcommandsHelp()
+    footer("""|
+              |Run 'daffodil generate <language> --help' for subcommand 
specific options""".stripMargin)
+
+    object c extends scallop.Subcommand("c") {

Review comment:
       "c-runtime2" would be good. There's definitely no reason to be trying to 
describe characteristics of the C code (thread safe or not etc.) in these 
identifiers, but the kind of thing being generated is C code, with runtime 2 in 
mind. 
   I'm ignoring that "runtime2" is itself a bit challenged as a name, but I've 
long believed that sometimes the best distinction between things is just "add a 
number" because trying to capture description in a short identifier is hard. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to