stevedlawrence commented on a change in pull request #478:
URL: https://github.com/apache/daffodil/pull/478#discussion_r620556619
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DaffodilParseXMLReader.scala
##########
@@ -194,8 +198,10 @@ class DaffodilParseXMLReader(dp: DataProcessor) extends
DFDL.DaffodilParseXMLRea
*
* @return SAXInfosetOutputter object with or without blob Attributes set
*/
- private def createSAXInfosetOutputter(xmlReader: DaffodilParseXMLReader):
SAXInfosetOutputter = {
- val sioo = new SAXInfosetOutputter(xmlReader)
+ private def createSAXInfosetOutputter(xmlReader: DaffodilParseXMLReader,
+ namespacesFeature: Boolean,
+ namespacePrefixesFeature: Boolean): SAXInfosetOutputter = {
Review comment:
I'm talking about passing things into the createSAXInfosetOutputter
function. We pass in the features as parameters, but not the properties. We
could easily pass in the properties, or we could pass in nothing and just have
this function access the private memebers directly. Not sure there's reason to
pass in features but not properties. And if list of features started to grow
big, then passing them in would be a pain.
I also suggest this fucntion is small enough and is only called in one place
that it might just be worth moving the logic in the the parse function. Then
you don't even need to worry about what gets passe in vs directly sued as
member vars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
