stevedlawrence commented on a change in pull request #478:
URL: https://github.com/apache/daffodil/pull/478#discussion_r620557787
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DaffodilParseXMLReader.scala
##########
@@ -144,7 +142,13 @@ class DaffodilParseXMLReader(dp: DataProcessor) extends
DFDL.DaffodilParseXMLRea
}
def parse(isdis: InputSourceDataInputStream): Unit = {
- val sio = createSAXInfosetOutputter(this)
+ val sio = createSAXInfosetOutputter(this,
+ saxNamespaceFeatureValue,
+ saxNamespacePrefixesFeatureValue)
+ // validate that the features are not false/false
+ if (!sio.namespacesFeature && !sio.namespacePrefixesFeature) {
Review comment:
Should we do this check before creating the sax infoset outputter? This
way we avoid creating a sax infoset outputter to just error and have it be
garbage collected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
