stevedlawrence commented on a change in pull request #539:
URL: https://github.com/apache/daffodil/pull/539#discussion_r621412682
##########
File path: daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/package.scala
##########
@@ -134,11 +134,11 @@ package org.apache.daffodil
* val is = new InputSourceDataInputStream(dataStream)
* val scalaOutputter = new ScalaXMLInfosetOutputter()
* val keepParsing = true
- * while (keepParsing) {
+ * while (keepParsing && is..hasData()) {
Review comment:
Double dots
##########
File path: daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/package.scala
##########
@@ -188,12 +188,12 @@ package org.apache.daffodil
* val contentHandler = new SAXHandler()
* xmlReader.setContentHandler(contentHandler)
* val keepParsing = true
- * while (keepParsing) {
+ * while (keepParsing && is..hasData()) {
Review comment:
Double dots
##########
File path:
daffodil-japi/src/main/java/org/apache/daffodil/japi/package-info.java
##########
@@ -209,12 +209,12 @@
* SAXHandler contentHandler = new SAXHandler();
* xmlReader.setContentHandler(contentHandler);
* Boolean keepParsing = true;
- * while (keepParsing) {
+ * while (keepParsing && is..hasData()) {
Review comment:
Same extra dot.
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DataLoc.scala
##########
@@ -33,9 +33,20 @@ import org.apache.daffodil.util.MaybeULong
import org.apache.daffodil.api.DataLocation
import org.apache.daffodil.processors.parsers.PState
-class DataLoc(val bitPos1b: Long, bitLimit1b: MaybeULong, val isAtEnd:
Boolean, eitherStream: Either[DataOutputStream, DataInputStream],
+class DataLoc(
+ val bitPos1b: Long,
+ bitLimit1b: MaybeULong,
+ eitherStream: Either[DataOutputStream, DataInputStream],
val maybeERD: Maybe[ElementRuntimeData]) extends DataLocation {
+ @deprecated("Use bitPos1b to compare with expected position (possibly
bitLimit1b).", "3.1.0")
+ override def isAtEnd =
+ eitherStream match {
+ case Right(isdis: InputSourceDataInputStream) => isdis.isAtEnd
Review comment:
All fair. Sounds good to me.
##########
File path:
daffodil-japi/src/main/java/org/apache/daffodil/japi/package-info.java
##########
@@ -151,11 +151,11 @@
* InputSourceDataInputStream is = new InputSourceDataInputStream(dataStream);
* JDOMInfosetOutputter jdomOutputter = new JDOMInfosetOutputter();
* boolean keepParsing = true;
- * while (keepParsing) {
+ * while (keepParsing && is..hasData()) {
Review comment:
Extra dot in ``is..hasData``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
