mbeckerle commented on a change in pull request #539:
URL: https://github.com/apache/daffodil/pull/539#discussion_r623934165



##########
File path: 
daffodil-runtime2/src/main/scala/org/apache/daffodil/runtime2/Runtime2DataProcessor.scala
##########
@@ -188,11 +196,13 @@ final class ParseResult(outfile: os.Path,
 }
 
 final class UnparseResult(val finalBitPos0b: Long,
-                          override val processorStatus: ProcessorResult,
-                          loc: DataLocation = Runtime2DataLocation())
+                          override val processorStatus: ProcessorResult)
   extends DFDL.UnparseResult
     with DFDL.State
     with WithDiagnosticsImpl {
+
+  val loc: DataLocation = Runtime2DataLocation(finalBitPos0b + 1, 
(finalBitPos0b + 1) / 8)
+
   /**

Review comment:
       comment added. Because DataLocation is 1-based numbers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to