stevedlawrence opened a new pull request #654:
URL: https://github.com/apache/daffodil/pull/654
The SAXInfosetOutputter and XMLTextInfosetOutputter used slightly
different logic to figure out namespace mappings to add to an element.
In complex cases with lots of includes, shared references, and
overlapping namespace bindings, this could cause inconsistent namespace
mappings, which causes failures in the TDMLRunner, which mandates
consistency between SAX and non-SAX. The SAX logic should be fine, but
our broken minimizedScope (DAFODIL-2282) leads to issues. By mimicking
the XMLTextInosetOututter logic (i.e. value equality check +
shadowRedefined), we avoid those issues.
Also, fix XML diff reporting of different prefixes and namespace
mappings. The changes are:
- Add the label to the path, otherwise we just output the elements
parent element and it isn't clear where the issue is
- Add @prefix or @xmlns to indicate the problem is related to
different prefixes or different namespace mappings
- For namespace reporting, only compare/report the mappings on the
particular element rather than the entire namespace binding. The
easiest way to do this is to keep track of the parent scope, use
NamespaceBinding.buildString(...) to create a string, and compare
that string.
DAFFODIL-2568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
