stevedlawrence commented on pull request #654: URL: https://github.com/apache/daffodil/pull/654#issuecomment-947699748
Sorry, I never addressed this comment: > The new test cases (complexIncludesNamespaces_01 and complexIncludesNamespaces_02) don't have any comments. I don't quite understand what they're supposed to demonstrate. Are they supposed to demonstrate that the SAX outputter no longer adds an unnecessary (that is, redundant) xmlns attribute, e.g., <raw xmlns:tns="urn:redundant-namespace">1</raw>? Yep, those schemas are heavily minimized/anonyized version of a much more complicated schema with lots of complex includes and namespace mappings. It's kindof a worse case of someone not following what we now know to be best practices when defining xml namespaces. This complexity, and how we output prefix mappings in SAX, led to an edge case where we added redundant namespace mappings, as you mention. Normally this wouldn't matter since they are redundant, but it meant that SAX infosets and non-SAX infosets weren't exactly the same, and the TDML runner currently enforces that, which caused a failure. I'll add a comment to the tdml file as Mike suggests to clarify things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
