mbeckerle commented on a change in pull request #37:
URL: https://github.com/apache/daffodil-vscode/pull/37#discussion_r731137434



##########
File path: README.md
##########
@@ -23,14 +23,79 @@
 
 This is a VS Code extension which enables the interactive debugging of DFDL 
schema parsing using [Apache Daffodil](https://daffodil.apache.org/).
 
+## Build Requirements
+- SDK 8 or higher
+- SBT 0.13.8 or higher
+- Node 10 or higher

Review comment:
       ... and installing yarn was problematic on Ubuntu, btw. because 
something else also called yarn, that is not the intended tool, is what 
installs when you just install yarn by default. 
   
   The above mentions SDK? Should be JDK, but I think you should say Java 
Development Kit (JDK) to be clear. 
   
   Also, don't we need Java 11 still, or did the things preventing Java 8 get 
fixed. Don't think I saw that yet. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to