stevedlawrence commented on a change in pull request #37:
URL: https://github.com/apache/daffodil-vscode/pull/37#discussion_r731162253
##########
File path: package.json
##########
@@ -31,7 +31,9 @@
"watch2": "tsc -watch -p ./",
"package": "vsce package",
"publish": "vsce publish",
- "package-ext": "webpack --mode production --config
./build/extension.webpack.config.js"
+ "package-ext": "webpack --mode production --config
./build/extension.webpack.config.js",
+ "sbt": "sbt universal:packageBin",
+ "build": "yarn sbt && yarn install && yarn compile && yarn package"
Review comment:
Cool!
Just a question about yarn, is this standard to have a yarn script run other
yarn scripts like this? Thinking how sbt works, you just specify command
dependencies. So you could specify that `yarn package` depends on `yarn
compile`, which depends on `yarn install`. That way you can tell people to just
run `yarn package` and if they haven't run the previous commands, they would
get run because they are dependent commands.
But maybe yarn doesn't work like that, and this `yarn build` is the standard
way to do this kind of thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
