jw3 commented on a change in pull request #44:
URL: https://github.com/apache/daffodil-vscode/pull/44#discussion_r736755927
##########
File path:
server/core/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala
##########
@@ -211,9 +211,10 @@ object Parse {
Either
.catchNonFatal(LaunchArgs.InfosetOutput.File(Paths.get(path.getAsString)))
.leftMap(t => s"'infosetOutput.path' field from
launch request is not a valid path: $t")
- .ensureOr(file => s"can't write to infoset output
file at ${file.path}")(
- _.path.toFile().canWrite()
- )
+ .ensureOr(file => s"can't write to infoset output
file at ${file.path}") { f =>
+ val file = f.path.toFile
+ file.exists && file.canWrite ||
file.getParentFile.canWrite
Review comment:
> But I'd suggest that the file existing but not writable should just
always be an error.
yeah, concur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
