jw3 commented on pull request #44: URL: https://github.com/apache/daffodil-vscode/pull/44#issuecomment-953044326
Keyword reference: https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests I think both the auto closing and traceability are nice. Then even if a PR doesn't close an issue you can mention the issue number without a keyword so they link. > Also, when squashing or creating commits, should we add Closes #XYZ to the end of the commit message? I would rely on linking in the PR and not explicitly adding it to commit messages. But not a strong opinion, it's just one less thing on the checklist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
