stevedlawrence commented on a change in pull request #42:
URL: https://github.com/apache/daffodil-vscode/pull/42#discussion_r736758866
##########
File path: src/adapter/activateDaffodilDebug.ts
##########
@@ -1,7 +1,19 @@
-/*---------------------------------------------------------------------------------------------
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
license information.
-
*--------------------------------------------------------------------------------------------*/
+/*
Review comment:
Correct. CTC and Nteligen and their employees all signed a software
grant, which granted their copyright of those files to ASF. So those copyright
headers must be updated to mention ASF. We didn't bother trying to get a grant
from Microsoft, since those files are not the main function of this codebase
and it's only a handful of files (and it's probably not possible).
Also, I just realized this, but the NOTICE file needs also be updated so the
copyright is ASF (see the Daffodil NOTICE file for an example). Though, we
should mention CTC/Nteligen in the "Based on source code originally developed
by" part.
As to the ratCheck update, my guess is Apache Rat won't be able to recognize
the headers in the MS files or the svg. But I would try running the check
first, and if it can't then you can modify the ratLicenses/ratLicenseFamilies
settings so it knows what to look for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
