mbeckerle commented on a change in pull request #686:
URL: https://github.com/apache/daffodil/pull/686#discussion_r758469284
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ExpressionEvaluatingParsers.scala
##########
@@ -161,15 +162,18 @@ class SetVariableParser(expr: CompiledExpression[AnyRef],
decl: VariableRuntimeD
}
}
-class NewVariableInstanceStartParser(override val context: VariableRuntimeData)
+final class NewVariableInstanceStartParser(vrd: VariableRuntimeData, trd:
TermRuntimeData)
extends PrimParser {
+
+ override def context = trd
Review comment:
Yes, this will change where blame is placed for the error. Fixing that
would require us to pass both the VRD and TRD down further into the software so
that the blame can be on the VRD, even though things like bitOrder must come
from the TRD.
Interesting that the def context is not covered by tests according to
codeCov. I will see if I can contrive a test that will force it to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
