mbeckerle commented on a change in pull request #686:
URL: https://github.com/apache/daffodil/pull/686#discussion_r759457551
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ExpressionEvaluatingParsers.scala
##########
@@ -161,15 +162,18 @@ class SetVariableParser(expr: CompiledExpression[AnyRef],
decl: VariableRuntimeD
}
}
-class NewVariableInstanceStartParser(override val context: VariableRuntimeData)
+final class NewVariableInstanceStartParser(vrd: VariableRuntimeData, trd:
TermRuntimeData)
extends PrimParser {
+
+ override def context = trd
Review comment:
Another commit adds tests that divide by zero in a setVariable
expression. We do get a diagnostic, but the behavior is poor as the line info
is way off. Added DAFFODIL-2594 and a test that characterizes this for now.
This bug fix does allow dfdl:newVariableInstance and dfdl:setVariable to
invoke dfdlx:lookAhead, so is worth having even if we fix the poor diagnostic
behavior later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
