[
https://issues.apache.org/jira/browse/DAFFODIL-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456485#comment-17456485
]
Steve Lawrence commented on DAFFODIL-2608:
------------------------------------------
Some other information: layers and their compute() function do have access to
LayerRuntimeInfo since it is passed into the constuctor of the layers, and the
compute() function can be called in a suspension. So it would be very easy for
a custom layer implementation to unknowingly use the wrong state if they use
LayerRuntimeInfo. We either need a way to update the state within the
LayerRuntimeInfo prior to calling compute() when in a suspension, or create a
new LayerRuntimeInfo and ensure layer implementations can only use that. Maybe
layerRuntimeInfo should always be passed into function and not into
constructors? That way we can create new ones with pointers to the correct
state?
> PCAP fails with Daf 3.2.0 and IPv4 layers with checksum
> -------------------------------------------------------
>
> Key: DAFFODIL-2608
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2608
> Project: Daffodil
> Issue Type: Bug
> Components: Back End
> Affects Versions: 3.2.0
> Reporter: Mike Beckerle
> Priority: Critical
>
> Updating PCAP to use the new ethernetIP with IPv4 (and Daffodil 3.2.0) is
> failing.
> Please look at https://github.com/DFDLSchemas/PCAP/pull/15
> Or you can clone my repo: [email protected]:mbeckerle/PCAP.git
> Checkout master branch
> $ sbt
> > testOnly *.TestPCAP -- --tests=test_pcap_test_dns
> Will reproduce the error.
> That test used to be a parserTestCase with roundTrip onePass. However, I have
> temporarily converted it into an unparserTestCase with roundTrip 'none' to
> isolate that this bug is only when unparsing.
> I think this is a Daffodil 3.2.0 bug.
> However, I recall somewhere bugs/errors like this being discussed not too
> long ago.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
