[ 
https://issues.apache.org/jira/browse/DAFFODIL-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456486#comment-17456486
 ] 

Mike Beckerle commented on DAFFODIL-2608:
-----------------------------------------

I'm pretty sure these suspensions need to use the variable maps in the frozen 
UState. Otherwise the variable instances they are modifying can change out from 
under them.

One of the things we definiitely need to do is define an API for this layering 
stuff that doesn't expose the wrong state objects. 

Once we get this bug fixed we can look at the ethernetIP schema's IPv4 and look 
carefully at what the API actually needs. Right now the layer jar just uses 
lots of Daffodil internals. 

> PCAP fails with Daf 3.2.0 and IPv4 layers with checksum
> -------------------------------------------------------
>
>                 Key: DAFFODIL-2608
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2608
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Back End
>    Affects Versions: 3.2.0
>            Reporter: Mike Beckerle
>            Priority: Critical
>
> Updating PCAP to use the new ethernetIP with IPv4 (and Daffodil 3.2.0) is 
> failing.
> Please look at https://github.com/DFDLSchemas/PCAP/pull/15
> Or you can clone my repo: [email protected]:mbeckerle/PCAP.git 
> Checkout master branch
> $ sbt
> > testOnly *.TestPCAP -- --tests=test_pcap_test_dns
> Will reproduce the error.
> That test used to be a parserTestCase with roundTrip onePass. However, I have 
> temporarily converted it into an unparserTestCase with roundTrip 'none' to 
> isolate that this bug is only when unparsing.
> I think this is a Daffodil 3.2.0 bug. 
> However,  I recall somewhere bugs/errors like this being discussed not too 
> long ago. 
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to