mbeckerle commented on a change in pull request #739:
URL: https://github.com/apache/daffodil/pull/739#discussion_r795807359
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -2585,64 +2613,85 @@ object UTF8Encoder {
}
-object TDMLCompileResultCache {
+case class TDMLCompileResultCacheKey(
+ impl: String,
+ suppliedSchema: DaffodilSchemaSource,
+ useSerializedProcessor: Boolean,
+ optRootName: Option[String],
+ optRootNamespace: Option[String],
+ tunables: Map[String, String],
+)
- case class Key (
- impl: String,
- suppliedSchema: DaffodilSchemaSource,
- useSerializedProcessor: Boolean,
- optRootName: Option[String],
- optRootNamespace: Option[String],
- tunables: Map[String, String],
- )
+/**
+ * Stores the compile result as well as the time when this compile result
+ * should be removed from the cache. If optExpireTime is set to None, it means
+ * a DFDLTestSuite exists that is using this compile result, and so it should
+ * not expire. If optExpireTime is set to Some, it means no DFDLTestSuite
+ * currently uses the compile result, and so it can be expired once we reach
+ * the current time reaches the Some value time
Review comment:
This is a good algorithm. I think just add this detail about the
re-extending of the timeout to comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
