tuxji commented on a change in pull request #739:
URL: https://github.com/apache/daffodil/pull/739#discussion_r796814936
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -2585,64 +2613,107 @@ object UTF8Encoder {
}
-object TDMLCompileResultCache {
+case class TDMLCompileResultCacheKey(
+ impl: String,
+ suppliedSchema: DaffodilSchemaSource,
+ useSerializedProcessor: Boolean,
+ optRootName: Option[String],
+ optRootNamespace: Option[String],
+ tunables: Map[String, String],
+)
- case class Key (
- impl: String,
- suppliedSchema: DaffodilSchemaSource,
- useSerializedProcessor: Boolean,
- optRootName: Option[String],
- optRootNamespace: Option[String],
- tunables: Map[String, String],
- )
+/**
+ * Stores the compile result as well as the time when this compile result
+ * should be removed from the cache.
+ *
+ * If optExpireTimeMillis is set to None, it means a DFDLTestSuite exists that
+ * is using this compile result, and so it will not expire.
+ *
+ * If optExpireTimeMillis is set to Some, it means no DFDLTestSuite currently
+ * uses the compile result, and so it can be expired once we reach the current
+ * time reaches the Some value time
Review comment:
Comment has some unnecessary words, would read better as:
```
* If optExpireTimeMillis is set to Some, it means no DFDLTestSuite currently
* uses the compile result, and it can be expired once the current time
reaches
* the Some value time
```
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -461,7 +461,20 @@ class DFDLTestSuite private[tdml] (
}
/**
- * Get the CompileResult from from the TDMLCompileResultCache.
+ * Get the CompileResult from a TDMLCompileResultCache.
+ *
+ * This uses one of two different caches to look for compile results:
+ *
+ * Embedded schemas cannot be shared among different DFDL Test Suites, so
+ * they are stored in a cache local to this test suite. This avoids having to
+ * run the expiration logic for such compile results, and the compile results
+ * will be garbage collected when this DFDL Test Suite is garbage collected.
Review comment:
Note that embedded schemas also are written to files in /tmp which
should be deleted after the tests finish, but currently are not cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
