Shanedell commented on code in PR #187:
URL: https://github.com/apache/daffodil-vscode/pull/187#discussion_r900438834
##########
package.json:
##########
@@ -62,17 +62,17 @@
"devDependencies": {
"@types/glob": "^7.1.3",
"@types/mocha": "^8.2.2",
- "@types/node": "^14.14.37",
+ "@types/node": "^18.0.0",
"@types/vscode": "^1.55.0",
"glob": "7.1.6",
- "mocha": "8.3.2",
+ "mocha": "10.0.0",
"prettier": "2.3.2",
"ts-loader": "8.1.0",
"typescript": "4.3.5",
- "vsce": "1.87.1",
+ "vsce": "2.9.1",
"vscode-debugadapter-testsupport": "1.46.0",
- "webpack": "4.46.0",
- "webpack-cli": "3.3.12"
+ "webpack": "5.40.0",
+ "webpack-cli": "4.10.0"
},
Review Comment:
I didn't mean to update the webpack items those were in part of testing the
other two things that broke items I will revert those.
But yes your are correct the `devDependencies` do not end up in the VSIX but
the items in `dependencies` do which is how we have everything setup. I also do
know that all but one of the items under `devDependencies` are ALv2 compatible.
Is the ISC license compatible with ALv2? `glob`
(https://github.com/isaacs/node-glob) is the only package under
`devDependencies` that uses something other MIT or AL.
As for the list question about the LICENSE/NOTICE information I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
