Shanedell commented on code in PR #187:
URL: https://github.com/apache/daffodil-vscode/pull/187#discussion_r900453729


##########
package.json:
##########
@@ -62,17 +62,17 @@
   "devDependencies": {
     "@types/glob": "^7.1.3",
     "@types/mocha": "^8.2.2",
-    "@types/node": "^14.14.37",
+    "@types/node": "^18.0.0",
     "@types/vscode": "^1.55.0",
     "glob": "7.1.6",
-    "mocha": "8.3.2",
+    "mocha": "10.0.0",
     "prettier": "2.3.2",
     "ts-loader": "8.1.0",
     "typescript": "4.3.5",
-    "vsce": "1.87.1",
+    "vsce": "2.9.1",
     "vscode-debugadapter-testsupport": "1.46.0",
-    "webpack": "4.46.0",
-    "webpack-cli": "3.3.12"
+    "webpack": "5.40.0",
+    "webpack-cli": "4.10.0"
   },

Review Comment:
   @stevedlawrence Pretty handy tool
   ```
   yarn global add license-checker
   ```
   then you can run
   ```
   license-checker --summary
   ```
   Here's the result
   ```
   ├─ MIT: 253
   ├─ ISC: 38
   ├─ BSD-3-Clause: 20
   ├─ BSD-2-Clause: 16
   ├─ Apache-2.0: 11
   ├─ MIT*: 2
   ├─ Python-2.0: 1
   ├─ Custom: http://github.com/substack/node-bufferlist: 1 # <-- MIT
   ├─ CC-BY-4.0: 1
   ├─ (MIT OR WTFPL): 1
   ├─ (BSD-2-Clause OR MIT OR Apache-2.0): 1
   └─ 0BSD: 1
   ```
   These all are approved correct? Only one I wasn't sure about/didn't see on 
the link you sent was `0BSD`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to