stevedlawrence commented on code in PR #232: URL: https://github.com/apache/daffodil-vscode/pull/232#discussion_r924641377
########## build/package/.vscodeignore: ########## @@ -17,8 +17,8 @@ */** !dist/ext/extension.js !images/* -!LICENSE -!NOTICE +# !LICENSE +# !NOTICE Review Comment: Why comment these out? Won't they be ignored otherwise and not be in the .vsix file? I guess our current behavior will be to copy LICENSE/NOTICE from the root, and then overwrite them from with the files in `build/package/`? It's a bit inefficient but maybe not a big deal? I'd rather than than have to have special casing for LICENSE/NOTICE. ########## build/scripts/package.ts: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// @ts-nocheck <-- This is needed as this file is basically a JavaScript script +// but with some TypeScript niceness baked in +const fs = require('fs') +const path = require('path') +const glob = require('glob') +const execSync = require('child_process').execSync +const pkg_dir = 'dist/package' + +async function copyGlob(pattern, dir = '.') { + glob(pattern, { cwd: dir }, (error, files) => { + for (var i = 0; i < files.length; i++) { + let src = path.join(dir, files[i]) + let dst = path.join(pkg_dir, files[i]) + let dstDir = path.dirname(dst) + + fs.mkdirSync(dstDir, { recursive: true }) + + if (fs.statSync(src).isFile()) { + fs.copyFileSync(src, dst) + } Review Comment: This means we ignore directories? As long as are globs only care about files in .vscodeignore I guess that's fine. I'm not sure what the right behavior should be if a glob did match a directory. Would it mean we would want to recursively copy the directory? Or maybe ignoring is the right behavior. I don't feel strongly about it, so this behavior is fine and we can deal with it when it comes up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
