stevedlawrence commented on code in PR #232:
URL: https://github.com/apache/daffodil-vscode/pull/232#discussion_r924758088
##########
build/package/.vscodeignore:
##########
@@ -17,8 +17,8 @@
*/**
!dist/ext/extension.js
!images/*
-!LICENSE
-!NOTICE
+# !LICENSE
+# !NOTICE
Review Comment:
As long as `copyGlob("*", "build/package")` is after the vscodeignore copy
it should be fine--it should just overwrite the ones copied from the root.
Which is maybe a nice feature and an easy way to override files copied from the
root if needed (e.g. maybe we'll want to to do that for the README file as well
(see issue #100)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
