mbeckerle commented on PR #225: URL: https://github.com/apache/daffodil-vscode/pull/225#issuecomment-1220516227
Two approvals, preferably by people working on the sub-effort who understand the nature of what is updating, and you are good to go. I thought we perhaps had a short checklist of what one is supposed to check about these before approving? @Steve Lawrence ***@***.***> ?? On Thu, Aug 18, 2022 at 9:50 PM Shane Dell ***@***.***> wrote: > @stevedlawrence <https://github.com/stevedlawrence> @mbeckerle > <https://github.com/mbeckerle> When it comes to these PRs for > daffodil-vscode, do you think it is fine to merge these items as long as > CI passes and both myself and @scholarsmate > <https://github.com/scholarsmate> approve? They have been sitting here > for a bit and would like to clear some out I believe a lot have approvals > from Davin and myself. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/daffodil-vscode/pull/225#issuecomment-1220150892>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALUDAZCVPEXO7SEKVBINVLVZ3R77ANCNFSM53UBFYFQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
