stevedlawrence commented on PR #225: URL: https://github.com/apache/daffodil-vscode/pull/225#issuecomment-1220578228
Merging code always requires 2 +1's from committers. No exceptions. The checklist is here: https://cwiki.apache.org/confluence/display/DAFFODIL/Scala+Steward This is what we usually use for review comments to meet this checklist: ``` - [] **Do all automated continuous integration checks pass?** - [] **Is the update a patch, minor, or major update?** - [] **Is the license still compatible with ASF License Policy?** - [] **Have any changes been made to LICENSE/NOTICE files that need to be incorporated?** - [] **Have any transitive dependencies been added or changed?** ``` Add an `X` to check off the boxes and add a comment below each line answering the question. Also, in general, when in the middle of a release (like now) I tend to avoid reviewing/merging changes so that if there is a new rc needed it minimizes changes and makes reviewing the next rc easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
