stevedlawrence commented on code in PR #342:
URL: https://github.com/apache/daffodil-vscode/pull/342#discussion_r1017165283
##########
package.json:
##########
@@ -3,7 +3,7 @@
"displayName": "Apache Daffodil VS Code Extension",
"description": "VS Code extension for Apache Daffodil DFDL schema
debugging",
"version": "1.1.0-SNAPSHOT",
- "daffodilVersion": "3.3.0",
+ "daffodilVersion": "3.4.0",
Review Comment:
> Would I just need to add in the updated NOTICE/LICENSE for the libraries
included in the -bin.zip file from the 3.4.0 release that aren't currently
listed?
Yep, that's correct. The NOTICE/LICENSE changes that I pointed to in that
commit are for the Daffodil CLI, which includes license information for a bunch
of jars. But VS Code doesn't depend on he CLI, it depends on daffodil-japi,
which transitively pulls in just a subset of what the CLI uses. So some of
those NOTICE/LICENSE changes don't affect VS Code since it doesn't pull them in
and redistribute them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
