Shanedell commented on code in PR #342:
URL: https://github.com/apache/daffodil-vscode/pull/342#discussion_r1017308244
##########
package.json:
##########
@@ -3,7 +3,7 @@
"displayName": "Apache Daffodil VS Code Extension",
"description": "VS Code extension for Apache Daffodil DFDL schema
debugging",
"version": "1.1.0-SNAPSHOT",
- "daffodilVersion": "3.3.0",
+ "daffodilVersion": "3.4.0",
Review Comment:
@stevedlawrence So between the daffodil-debugger zip and the daffodil bin
zip I found all these items
```txt
1.) Listed in daffodil-debugger zip, need added:
- com.fasterxml.woodstox.woodstox-core
- com.google.code.gson.gson
- com.monovore.decline-effect
- com.monovore.decline
- com.typesafe.config
- io.reactivex.rxjava2.rxjava
- org.typelevel.cats-effect-kernel
- org.typelevel.cats-effect-std
- org.typelevel.cats-effect
- org.typelevel.literally
- org.typelevel.log4cats-core
- org.typelevel.log4cats-slf4j
2.) Listed in daffodil 3.4.0, may need added:
- org.apache.daffodil.daffodil-cli
- org.apache.daffodil.daffodil-japi
- org.apache.daffodil.daffodil-runtime2
- org.apache.daffodil.daffodil-tdml-lib
- org.apache.daffodil.daffodil-tdml-processor
3.) Listed in daffodil 3.4.0, may not need added (listed as part of
daffodil-cli deps):
- com.siemens.ct.exi.exificient
- com.siemens.ct.exi.exificient-core
- com.siemens.ct.exi.exificient-grammars
- com.sun.xml.bind.jaxb-core
- com.sun.xml.bind.jaxb-impl
- commons-codec.commons-codec
- javax.activation.activation
- javax.xml.bind.jaxb-api
- net.sf.saxon.Saxon-HE
- org.apache.daffodil.daffodil-schematron
- org.apache.httpcomponents.client5.httpclient5
- org.apache.httpcomponents.core5.httpcore5
- org.apache.httpcomponents.core5.httpcore5-h2
- org.apache.logging.log4j.log4j-core
- org.fusesource.jansi.jansi
- org.jline.jline
- org.rogach.scallop
- org.xmlresolver.xmlresolver
- xmlpull.xmlpull
```
Would I just need the dependencies listed in 1 or 1 and 2? I assume the deps
listed in 3 do not need added as they seemed to be related to daffodil-cli
correct? Also would you like them added as part of this PR or a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
