Shanedell commented on code in PR #875:
URL: https://github.com/apache/daffodil/pull/875#discussion_r1024159861
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/XMLTextInfosetInputter.scala:
##########
@@ -191,9 +191,6 @@ object XMLTextInfoset {
class XMLTextInfosetInputter private (input: Either[java.io.Reader,
java.io.InputStream])
Review Comment:
Removing the `Either` seems to cause issue with the `this` constructor.
Removing the extra `this` constructor cases other issues, example error message
```sbt
[error]
daffodil-tdml-processor/src/main/scala/org/apache/daffodil/tdml/TDMLInfosetOutputter.scala:55:18:
constructor JsonInfosetInputter in class JsonInfosetInputter cannot be
accessed in class TDMLInfosetOutputter
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
