[ 
https://issues.apache.org/jira/browse/DAFFODIL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636718#comment-17636718
 ] 

John Interrante commented on DAFFODIL-2743:
-------------------------------------------

Pulled commit c1ec8706ee76415b7ae492d0542b775fcc0eab49 and grep'ed the 
repository for "deprecated" again.  Expected to find only deprecated properties 
(old DFDL schemas will break if we remove these) but found two more places we 
may want to remove.


daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala
345: * The root element can be specified by a deprecated API call on the 
compiler



daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DataProcessor.scala
165: * The compilerExternalVars argument supports the deprecated feature to 
assign external var bindings


The first place is simply an out of date scaladoc for the root member which 
needs to be rewritten.

The second place is not only a scaladoc, I think it indicates we have an unused 
parameter compilerExternalVars which needs to be removed from DataProcessor's 
constructors.  If I am right, your IDE should have a warning on that parameter 
saying it is unused.

> remove all deprecated methods/classes/objects
> ---------------------------------------------
>
>                 Key: DAFFODIL-2743
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2743
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Clean Ups
>    Affects Versions: 3.4.0
>            Reporter: Mike Beckerle
>            Assignee: Shane Dell
>            Priority: Major
>             Fix For: 3.5.0
>
>
> There are now 170 occurrences of "@deprecated" in the daffodil libraries.
> Next major release these should all be removed. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to