stevedlawrence commented on code in PR #821:
URL: https://github.com/apache/daffodil/pull/821#discussion_r1038086194
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DataProcessor.scala:
##########
@@ -372,7 +372,7 @@ class DataProcessor private (
validationMode match {
case ValidationMode.Full | ValidationMode.Custom(_) =>
val bos = new java.io.ByteArrayOutputStream()
- val xmlOutputter = new XMLTextInfosetOutputter(bos, false)
+ val xmlOutputter = new XMLTextInfosetOutputter(bos, false,
tunables.xmlOutputStyle)
Review Comment:
Yeah, I prefer we come up with something other than tunables for configuring
these in the CLI, otherwise I think it becomes confusing when it is set.
In this particular case, this XMLTexInfosetOutputter should always have
pretty-print safe disabled because this XMLTextInfostOutputter is only used for
Xerces validation and the user will never see it and we don't have to worry
about something reformatting and breaking the infoset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
